[Buildroot] [PATCH 1/1] qt: convert to the GENTARGETS infrastructure
jacmet at uclibc.org
Sun Mar 27 22:07:40 UTC 2011
>>>>> "Will" == Will Wagner <will_wagner at carallon.com> writes:
Will> I have found three issues with this patch:
Will> Should be:
Will> +else ifeq ($(BR2_i386),y)
Will> +else ifeq ($(BR2_x86),y)
Will> Should be:
Will> ifneq ($(findstring x86,$(QT_EMB_PLATFORM)),)
Will> ifneq ($(findstring x86,$(BR2_PACKAGE_QT_EMB_PLATFORM)),)
Will> Finally whitespace formatting is slightly inconsistent for the
Will> QT_DEPENDENCIES libglib2, directfb and tslib
Will> Assuming you fixup those three minor things
Will> Acked-by: Will Wagner <willw at carallon.com>
Will> As a slight aside I have a number of Qt patches in my tree that I'd
Will> love to get merged if there was any interest.
Will> First is to allow compiling Qt for X11 rather than embedded. This is
Will> involves a slight hack as Qt doesn't officially support cross
Will> compiling the X11 version, however I have it working well and have
Will> been in touch with Nokia support who say that although not officially
Will> supported it should work
Will> Second is re-adding commercial support. i know we had this before and
Will> it was removed, however I'm stuck with some projects that have to use
Will> the commercial license. I have done it slightly differently to how it
Will> was before, it no longer needs login details to download the tarball,
Will> instead it just fails with an explanation if it isn't in your
Will> buildroot dl folder.
Will> Other patches include Qt Declarative config option, more font config
Will> If people are interested I'll submit patches.
I am, please submit - I'll add them If they are not too intrusive.
Bye, Peter Korsgaard
More information about the buildroot