[Buildroot] Add Package: htop

Mike Frysinger vapier at gentoo.org
Tue Mar 22 15:38:53 UTC 2011


On Tue, Mar 22, 2011 at 11:18 AM, Andy Kennedy wrote:
> --- a/package/htop/htop-alloc-not-void.patch    1969-12-31 18:00:00.000000000 -0600
> +++ b/package/htop/htop-alloc-not-void.patch    2011-03-21 18:09:45.000000000 -0500
> @@ -0,0 +1,21 @@
> +diff -Naur a/configure b/configure
> +--- a/configure        2010-11-23 10:33:53.000000000 -0600
> ++++ b/configure        2011-03-21 18:05:46.000000000 -0500
> +@@ -12363,7 +12363,7 @@
> + #if defined STDC_HEADERS || defined HAVE_STDLIB_H
> + # include <stdlib.h>
> + #else
> +-char *malloc ();
> ++void *malloc ();
> + #endif
> +
> + int
> +@@ -12598,7 +12598,7 @@
> + #if defined STDC_HEADERS || defined HAVE_STDLIB_H
> + # include <stdlib.h>
> + #else
> +-char *realloc ();
> ++void *realloc ();
> + #endif

why do you need to patch this ?  HAVE_STDLIB_H should be defined, or
something else is broken.

> +--- a/configure
> ++++ b/configure

so you patch configure ...

> +--- a/configure.ac
> ++++ b/configure.ac

then you patch configure.ac ...

> +HTOP_POST_CONFIGURE_HOOKS = HTOP_RETOUCH_CONFIGURE_AC
> +
> +define HTOP_RETOUCH_CONFIGURE_AC
> +       touch -r $(@D)/missing $(@D)/configure.ac
> +endef

and then you manually touch configure.ac, but dont invoke autotools
anywhere.  what is going on here ?

you should only be patching generated files, or only the source
autotool files.  and if you do the latter, you should be re-running
autotools via HTOP_AUTORECONF=yes, not manually mucking with
timestamps and letting the build system figure things out.
-mike



More information about the buildroot mailing list