[Buildroot] [PATCH 01/10] input-tools: convert to gentargets

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Oct 5 09:17:15 UTC 2010


Hello,

Thanks Martin for doing all this conversion work, this is much
appreciated!

On Tue,  5 Oct 2010 01:22:34 -0700
Martin Banky <martin.banky at gmail.com> wrote:

> +define INPUT_TOOLS_DEBIAN_PATCHES
> +	if [ -d $(@D)/debian/patches ]; then \
> +		(cd $(@D)/debian/patches && for i in *; \
> +		 do $(SED) 's,^\+\+\+ .*joystick-$(INPUT_TOOLS_VERSION)/,+++ joystick-$(INPUT_TOOLS_VERSION)/,' $$i; \

I have seen this in several of your patches, but I don't understand why
it is here. There are several other packages that do apply the debian
patches, but such a sed step is not needed.

> +define INPUT_TOOLS_BUILD_CMDS
> +	$(INPUT_TOOLS_DEBIAN_PATCHES)

Even though it doesn't technically make any difference, I'd prefer to
have this as a post-patch hook.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the buildroot mailing list