[Buildroot] [PATCH] initial support for Blackfin processors

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Nov 18 10:53:32 UTC 2010


Nice to see support for Blackfin processors!

On Thu, 18 Nov 2010 05:27:24 -0500
Mike Frysinger <vapier at gentoo.org> wrote:

> diff --git a/boot/u-boot/Config.in b/boot/u-boot/Config.in
> index 86c656d..47657fc 100644
> --- a/boot/u-boot/Config.in
> +++ b/boot/u-boot/Config.in
> @@ -71,6 +71,10 @@ config BR2_TARGET_UBOOT_FORMAT_KWB
>  	depends on BR2_arm
>  	bool "u-boot.kwb (Marvell)"
> +	depends on BR2_bfin
> +	bool "u-boot.ldr"
> +

Maybe make it the default choice when BR2_bfin is enabled ?

>  ifeq ($(BR2_LINUX_KERNEL_UIMAGE),y)
> +ifeq ($(KERNEL_ARCH),blackfin)
> +else
> +endif

That looks strange, if you want uImage, you want uImage, right ? Or is
Blackfin's vmImage in fact a uImage (in which case a short comment
above this condition would be nice).

>  choice
>  	prompt "Serial port to run a getty on"
> +	default BR2_TARGET_GENERIC_GETTY_TTYS0 if !BR2_bfin
> +	default BR2_TARGET_GENERIC_GETTY_TTYBF0 if BR2_bfin

We are going to move away from this and replace all that stuff by a
free-form text field. Patches have been posted, but haven't been merged
yet. As I am reworking board support and system-level configuration, I
think I'll take care of them.

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.

More information about the buildroot mailing list