[Buildroot] [PATCH 04/12] autotools: introduce $(PKG_NAME)_AUTORECONF_ENV/$(PKG_NAME)_AUTORECONF_OPT variables

Lionel Landwerlin llandwerlin at gmail.com
Thu Nov 4 13:49:36 UTC 2010


Ok... this set of patch is a bunch of crap...
That would teach me to rebase things at 3:30am :)

Thanks again for reviewing.

Regards,

--
Lionel Landwerlin

On Thu, Nov 4, 2010 at 2:44 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Hello,
>
> On Thu,  4 Nov 2010 03:50:23 +0100
> llandwerlin at gmail.com wrote:
>
>> Rather than defining the AUTORECONF variable containing the path to
>> the autoreconf tool + all its arguments, we split the variable in two.
>> There is now :
>>       - AUTORECONF which contains the path to the autoreconf tool,
>>       - $(PKG_NAME)_AUTORECONF_OPT which contains the autoreconf arguments,
>>
>>       - and we add $(PKG_NAME)_AUTORECONF_ENV which contains the autoreconf
>>         environment variables.
>>
>> This allow us to define a specific setup to run autoreconf for both
>> target and host as well as per package if needed.
>
> Ok on the principle, but see comment below.
>
>> +      <li><code>LIBFOO_AUTORECONF_OPT</code> to specify additional
>> +      options passed to the <i>autoreconf</i> program
>> +      if <code>LIBFOO_AUTORECONF=YES</code>. By default, empty.</li>
>
> Seems to be a duplication of :
>
>> +      <li><code>LIBFOO_AUTORECONF_OPT</code>, to specify options
>>        passed to the <i>autoreconf</i> program if
>> -      <code>LIBFOO_AUTORECONF=YES</code>. By default, empty.</li>
>> +      <code>LIBFOO_AUTORECONF=YES</code>. By default, <code>-f -i -I
>> +      "$(ACLOCAL_DIR)"</code>.</li>
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>


More information about the buildroot mailing list