[Buildroot] svn commit: trunk/buildroot/package/multimedia/gst-plugins-good

Daniel Laird danieljlaird at hotmail.com
Wed Jan 21 15:56:30 UTC 2009

Ok I will change to use select.

laird> +comment "plugins with external dependencies (more to come)"
 laird> +

The package has a number of plugins with external dependencies the 5 I have
added are ones that seems to end up being built by default but then fail due
to missing dependencies (ESD being first culprit).  The others plugins I
have not added as I have not tested them yet and the out of box 'untar;
configure; make' did not try making them.  I was trying to limit the scope
of the change with RC being done. 

-----Original Message-----
From: buildroot-bounces at busybox.net [mailto:buildroot-bounces at busybox.net]
On Behalf Of Peter Korsgaard
Sent: 2009 Jan 21 13:40
To: buildroot at uclibc.org
Subject: Re: [Buildroot] svn commit:

>>>>> "laird" == laird  <laird at uclibc.org> writes:

 laird> Author: laird
 laird> Date: 2009-01-21 13:33:21 +0000 (Wed, 21 Jan 2009)
 laird> New Revision: 24937

 laird> Log:
 laird> package/multimedia/gst-plugins-good/gst-plugins-good.mk
 laird> package/multimedia/gst-plugins-good/Config.in

 laird> gst-plugins-good does not build unless some package dependencies are
 laird> This patch allows you to turn off some of the plugins with these
dependencies and hides
 laird> others that require some packages (like PNG/JPEG)

 laird> Signed-off-by: Daniel Laird <daniel.j.laird at nxp.com>

 laird>  	bool "matroska"
 laird> +	depends on BR2_PACKAGE_BZIP2 && BR2_PACKAGE_ZLIB

I prefer to use select for library dependencies. How is the user
supposed to know that bzip2 and zlib needs to be enabled to even see
the matroska option.

 laird>  	bool "monoscope"
 laird> @@ -119,4 +120,25 @@
 laird>  	bool "wavparse (*.wav audio)"
 laird>  	default y
 laird> +comment "plugins with external dependencies (more to come)"
 laird> +

What is this comment supposed to mean? That these things don't build
right now?

Bye, Peter Korsgaard
buildroot mailing list
buildroot at busybox.net

More information about the buildroot mailing list