[Buildroot] svn commit: trunk/buildroot/package/liberation

Daniel James Laird daniel.j.laird at nxp.com
Mon Jan 12 14:19:54 UTC 2009

I will try and improve this makefile as per your suggestions and then submit it back in.
Cheers for the feedback

-----Original Message-----
From: buildroot-bounces at busybox.net [mailto:buildroot-bounces at busybox.net] On Behalf Of Bernhard Reutner-Fischer
Sent: 2009 Jan 12 13:06
To: buildroot at uclibc.org
Cc: laird at uclibc.org
Subject: Re: [Buildroot] svn commit: trunk/buildroot/package/liberation

On Mon, Jan 12, 2009 at 12:40:48PM +0000, laird at uclibc.org wrote:
>Author: laird
>Date: 2009-01-12 12:40:48 +0000 (Mon, 12 Jan 2009)
>New Revision: 24792
>package/liberation/liberation.mk: Correct the makefile to what it should have been
>Correct the makefile so that it works and is what I originally planned to add.
>Signed-off-by: Daniel Laird <daniel.j.laird at nxp.com>
>   trunk/buildroot/package/liberation/liberation.mk
>Modified: trunk/buildroot/package/liberation/liberation.mk
>--- trunk/buildroot/package/liberation/liberation.mk	2009-01-12 10:29:46 UTC (rev 24791)
>+++ trunk/buildroot/package/liberation/liberation.mk	2009-01-12 12:40:48 UTC (rev 24792)
>@@ -18,12 +18,12 @@
> 	touch $(LIBERATION_DIR)/.unpacked

touch $@
>-$(STAGING_DIR)/usr/share/fonts/.ttf: $(LIBERATION_DIR)/.unpacked
>+$(STAGING_DIR)/usr/share/fonts/LiberationMono-Bold.ttf: $(LIBERATION_DIR)/.unpacked
> 	-mkdir -p $(STAGING_DIR)/usr/share/fonts/liberation

The preferred thing to do is to use $(INSTALL) -d $(@D)

> 	$(INSTALL) -m0644 $(LIBERATION_DIR)/*.ttf $(STAGING_DIR)/usr/share/fonts/liberation/

okay.. the target is fonts/LiberationMono-Bold.ttf and you put the fonts into

> 	touch -c $(STAGING_DIR)/usr/share/fonts/.ttf

See how it would be *so* much better to use 'touch -c $@' ?

>-$(TARGET_DIR)/usr/share/fonts/LiberationMono-Bold.ttf: $(STAGING_DIR)/usr/share/fonts/.ttf
>+$(TARGET_DIR)/usr/share/fonts/LiberationMono-Bold.ttf: $(STAGING_DIR)/usr/share/fonts/LiberationMono-Bold.ttf
> 	-mkdir -p $(TARGET_DIR)/usr/share/fonts/liberation
> 	$(INSTALL) -m0644 $(LIBERATION_DIR)/*.ttf $(TARGET_DIR)/usr/share/fonts/liberation/
> 	touch -c $(TARGET_DIR)/usr/share/fonts/.ttf

about the same 3 bugs as above.
Please, be more careful..
buildroot mailing list
buildroot at busybox.net

More information about the buildroot mailing list