[Buildroot] Updating toolchain config options to help external toolchain support.
danieljlaird at hotmail.com
Fri Jan 30 14:26:23 UTC 2009
I am ready to commit this change, but wanted to respond to the comments:
Reshuffling of options?
The reason for this is to make sure the options are the same for all
toolchains in buildroot. Without moving them around etc I got extra things
being selected, or duplicate symbols or repeated symbols etc and moving them
around and to the top level meant 1 option covered what ever toolchain you
The Gettext comments changed from:
- 'Enable locale/gettext/i18n support?', why the change?
+ "Toolchain built with locale/gettext/i18n support?"
This was an oversight and have returned it to its previous text.
I commited the QTE separately.
As mentioned in another reply this makes external toolchain support equal
(in options) to internal toolchains. However I like to the idea of config
files per toolchain and having no options in the future. Not quite sure how
it work work but the suggestion is a good one.
From: buildroot-bounces at busybox.net [mailto:buildroot-bounces at busybox.net]
On Behalf Of Peter Korsgaard
Sent: 2009 Jan 29 17:03
To: Daniel James Laird
Cc: buildroot at uclibc.org
Subject: Re: [Buildroot] Updating toolchain config options to help external
>>>>> "Daniel" == Daniel James Laird <daniel.j.laird at nxp.com> writes:
Daniel> After a lot a playing around I have made some changes to the
Daniel> toolchain configuration options. This now allows users of
Daniel> external binary toolchains to enable/disable the same set of
Daniel> features as those who are building a toolchain using
Daniel> buildroot or external source. However the number of changes
Daniel> mean that I would like to post the patch below for comments
Daniel> before commiting it. I have tested the external toolchain
Daniel> support side of things and checked the options are all ok but
Daniel> I have not built a new buildroot toolchain (never done this)
Daniel> perhaps someone can comment on patch below: If not I would
Daniel> like to commit by friday to enable a few days testing before
Daniel> final release.
It seems to work here - A few comments:
The reshuffle of configuration settings makes it fairly hard to find
stuff for existing users - I wonder if this is all worth it as these
things don't change very often.
Daniel> +config BR2_ENABLE_LOCALE
Daniel> + bool "Toolchain built with locale/gettext/i18n support?"
The text used to be 'Enable locale/gettext/i18n support?', why the change?
Daniel> --- package/qte/Config.in (revision 25087)
Daniel> +++ package/qte/Config.in (working copy)
Daniel> @@ -2,7 +2,7 @@
Daniel> bool "Qt/E"
Daniel> depends on BR2_DEPRECATED
Daniel> depends on BR2_INSTALL_LIBSTDCPP
Daniel> - select BR2_PTHREADS_NATIVE
Daniel> + depends on BR2_PTHREADS_NATIVE
This should go in a seperate commit, and have a comment entry like for
the other packages depending on toolchain config.
Bye, Peter Korsgaard
buildroot mailing list
buildroot at busybox.net
More information about the buildroot