[Buildroot] [PATCH] package: don't default to y for categories

Peter Korsgaard jacmet at uclibc.org
Fri Nov 14 11:43:01 UTC 2008


>>>>> "Hans-Christian" == Hans-Christian Egtvedt <hans-christian.egtvedt at atmel.com> writes:

Hi,

 >> In our case, the categories « Graphical libraries », « Audio stuff »
 >> and others do not lead to anything being compiled, except if I'm
 >> wrong. So I would say that we shouldn't be able to select/unselect the
 >> categories. They should just be submenus, to organize the options, not
 >> more.
 >> 

 Hans-Christian> Ah, even more sane. I think I for long time ago
 Hans-Christian> (probably fixed now) that LZO was not compiled if the
 Hans-Christian> compression menu was not selected. LZO was selected
 Hans-Christian> by some other packages in a different sub menu.

I actually think that's still the case as we don't source the
Config.in files of the stuff in the sub menus if the menu isn't
enabled.

 >> Look at the top of the kernel configuration system. Networking support
 >> can be enabled/disabled as a whole, while Device Drivers is just a
 >> submenu. Our categories should be like Device Drivers, IMO.
 >> 

 Hans-Christian> Yes, that is smoother IMHO.

I agree. I'll change the sub menus to use menu / endmenu instead of
menuconfig. This does mean that you no longer can deselect all
packages in a submenu simply by deselecting the menu, but as all
packages default to n that shouldn't be a big deal.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list