[Buildroot] [PATCH] Fix nbd compile

Thiago A. Corrêa thiago.correa at gmail.com
Wed Jun 18 15:29:17 UTC 2008


Or libraries could provide a variable that we could use on depends.

At least this way, packages won't be broken if we decide to revamp
some library makefile.

On Wed, Jun 18, 2008 at 12:16 PM, Bernhard Fischer
<rep.dot.nop at gmail.com> wrote:
> On Wed, Jun 18, 2008 at 05:09:24PM +0200, Peter Korsgaard wrote:
>>>>>>> "Thiago" == Thiago A Corrêa <thiago.correa at gmail.com> writes:
>>
>> Thiago> This will fix nbd compile, since all versions after 2.8 now
>> Thiago> depends on glib.
>>
>>Thanks, committed.
>>
>>The only issue I saw was:
>>
>>-nbd: uclibc $(TARGET_DIR)/sbin/nbd-client
>>+nbd: uclibc libglib2 $(TARGET_DIR)/sbin/nbd-client
>>
>>which doesn't work for parallel builds (libglib's staging install
>>might not have completed before the configure step of nbd
>>runs). Unfortunately this isn't easy to do with Makefile.autootools.in
>>as the libglib version number is part of the .stamp_staging_installed
>>path, and LIBGLIB2_TARGET_INSTALL_STAGING isn't defined yet if
>>libglib2.mk gets parsed later than nbd.mk.
>>
>>Perhaps we should get rid of the package version in the stamp files?
>>That would ofcause break if you changed package version, but it might
>>be preferable to what we have now - E.G.:
>>
>>$(BUILD_DIR)/libglib2_stamp_staging_installed
>
>
> echo the current package version into a .test_ver file in the toplevel
> builddir, then cmp(1) .test_ver
> $(BUILD_DIR)/$(PACK)_stamp_staging_installed. If cmp returns !0 then
> rebuild and update the current version into the stamp-file
>



More information about the buildroot mailing list