[PATCH] arm: add RESET_PID in the clone impl

wangyufen wangyufen at huawei.com
Fri Sep 5 06:49:51 UTC 2014


On 2014/9/4 19:40, Bernhard Reutner-Fischer wrote:
> On 4 September 2014 00:01, Waldemar Brodkorb <wbx at openadk.org> wrote:
>> Hi Carmelo,
>> Carmelo Amoroso wrote,
>>
>>> Hi,
>>> I don't think clone on arm is missing RESET_PID if you use the
>>> correct implementation from
>>> libpthread/nptl/sysdeps/unix/sysv/linux/arm/clone.S.
>>
>> Can you explain this a little bit more?
>>
>> cat ./libpthread/nptl/sysdeps/unix/sysv/linux/arm/clone.S
>> #define RESET_PID
>> #include <tcb-offsets.h>
>> #include "../../../../../../../libc/sysdeps/linux/arm/clone.S"
>>
>> Do you think the test-suite failures on arm come from a buildsystem
>> problem?
> 
> No, the patch is fine and needed.
> ARCH_HAS_BX and ARCH_HAS_BLX should be deleted though, we handle that
> via bits/arm_bx.h

Actually,to fix missing RESET_PID, I just need ARCH_HAS_HARD_TP.
I'll resend the patch.

Regards,
Wang

> Can somebody run this through a test-harness for !threads and NPTL on
> the affected ISA revisions just to be sure?
> 
> That'd help.
> TIA,
> _______________________________________________
> uClibc mailing list
> uClibc at uclibc.org
> http://lists.busybox.net/mailman/listinfo/uclibc
> 
> 




More information about the uClibc mailing list