[PATCH] libc: add issetugid()

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Sun Jul 27 17:30:20 UTC 2014


On 27 July 2014 11:36:00 CEST, Rich Felker <dalias at libc.org> wrote:
>On Sat, Jul 26, 2014 at 08:12:53AM -0400, Anthony G. Basile wrote:
>> On 07/24/14 16:41, Bernhard Reutner-Fischer wrote:
>> >On Wed, Jul 23, 2014 at 07:28:26AM -0400, Anthony G. Basile wrote:

>> >>>
>> >>>  #endif	/* Use misc.  */
>> >>>
>> >>>+#ifdef __USE_MISC
>> >
>> >is MISC (or MISC alone) an appropriate guard?
>> 
>> I had a hard time (and still have a hard time) deciding this even
>> after carefully reading include/features.h.  The function started in
>> openbsd and migrated to free and netbsd, but its not in 4.3BSD.
>> _USE_MISC is looser but does include SYS V.  I'm thinking now to
>> just remove the guard.  I did speak to Rich about what musl's doing
>> but it doesn't seem appropriate here.
>> 
>> If there are no strong opinions, I'll just remove the guard and
>> resubmit in a few days.
>> 
>> Your other comments below are good.
>
>I don't think removing the guard would be correct at all; that would
>expose it even in profiles where the namespace is supposed to conform
>to POSIX/XSI. If __USE_MISC is inappropriate, the solution would be to
>move it to a more-inclusive featureset, not a less-inclusive one.

Indeed.




More information about the uClibc mailing list