[PATCH] libpthread: modify CFLAGS-pthread_once.c to avoid earlier setting being replaced

Waldemar Brodkorb wbx at openadk.org
Sun Aug 31 08:40:37 UTC 2014


Hi Yang,
Yang Yingliang wrote,

> I use uclibc in arch arm. The CFLAGS-pthread_once.c has been set
> to -DNOT_IN_libc -DIS_IN_libpthread in
> libpthread/nptl/sysdeps/unix/sysv/linux/arm/Makefile.arch.
> But it will be replaced by -fexceptions -fasynchronous-unwind-tables in
> libpthread/nptl/Makefile.in.
> 
> If CFLAGS-pthread_once.c has no -DIS_IN_libpthread the testcase
> tst-once3 in test/nptl/ will be failed. The reason is pthread_once
> calls another pthread_cleanup_push() which is not under IS_IN_libpthread
> so that clear_once_control do not be called when the thread is canceled.
> So pthread_once will hang up when it's called second time.
> 
> Signed-off-by: Yang Yingliang <yangyingliang at huawei.com>

You can add a Tested-by: Waldemar Brodkorb <wbx at openadk.org>

Fixes my tst-once3 problem on at least arm and mips.
http://openadk.org/test/

best regards
 Waldemar


More information about the uClibc mailing list