[PATCH] test/math: fix for disabled long double math

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Mon Aug 18 10:12:15 UTC 2014


On Wed, Aug 13, 2014 at 04:04:45PM +0400, Alexey Brodkin wrote:
> Commit "test: cater for config" http://git.uclibc.org/uClibc/commit/test/math/Makefile.in?id=7598eeaa1defa2884adaa890bb115c493d69cc35 inverted check from
> 	ifeq ($(UCLIBC_HAS_LONG_DOUBLE_MATH),y)
> to
> 	ifeq ($(UCLIBC_HAS_LONG_DOUBLE_MATH),)
> with first branch indeed inverted - instead of adding tests they were excluded.
> But "else" branch was not moved up (remember check was inverted).
> 
> This causes compile breakage when building basic-test.c:
> --->---
> TEST_LINK math/ basic-test
> basic-test.c: In function 'ldouble_test':
> basic-test.c:111:1: warning: implicit declaration of function 'nanl' [-Wimplicit-function-declaration]
>  TEST_FUNC (ldouble_test, long double, nanl, LDBL_EPSILON, HUGE_VALL)
>  ^
> basic-test.o: In function `main':
> basic-test.c:(.text.startup+0x834): undefined reference to `nanl'
> basic-test.c:(.text.startup+0x858): undefined reference to `nanl'
> basic-test.c:(.text.startup+0x880): undefined reference to `nanl'
> basic-test.c:(.text.startup+0x8a8): undefined reference to `nanl'
> basic-test.c:(.text.startup+0x8d4): undefined reference to `nanl'
> basic-test.o:basic-test.c:(.text.startup+0x8e0): more undefined references to `nanl' follow
> collect2: error: ld returned 1 exit status
> make[3]: *** [basic-test] Error 1
> --->---
> 
> Fix is simple - merge "old else" branch with the first current one.

Applied, thanks!


More information about the uClibc mailing list