uClibc trunk broken

[Bernhard Reutner-Fischer]

On 16 March 2013 05:57:26 Vineet Gupta <Vineet.Gupta1 at synopsys.com> wrote:
> Hi Bernhard,
>
> On Friday 15 March 2013 08:47 PM, Bernhard Reutner-Fischer wrote:
> > On 15 March 2013 12:53:55 Vineet Gupta <Vineet.Gupta1 at synopsys.com> wrote:
> >> Hi Bernhard,
> >>
> >> It seems that 950fcf0f68732a9aafaIt "inet: res_nclose: free 
> user-buffer" breaks
> >> the build. This is on ARC port with linthreads.old
> >>
> >> --------------------->8-----------------------------
> >> In file included from libc/inet/res_init.c:8:
> >> libc/inet/resolv.c: In function '__res_iclose':
> >> libc/inet/resolv.c:3539: error: '__resp' undeclared (first use in 
> this function)
> >
> > Yes, that should read __res_state() instead.
> > Can you confirm this?
>
> Not sure what you mean, there's no function named __res_state()
> I suppose it needs to fallback to usage of global _res, something like below
>
> ------------------------>
> diff --git a/libc/inet/resolv.c b/libc/inet/resolv.c
> index 769b65f..290bced 100644
> --- a/libc/inet/resolv.c
> +++ b/libc/inet/resolv.c
> @@ -3536,7 +3536,7 @@ __res_iclose(res_state statp)
>         struct __res_state * rp = statp;
>         __UCLIBC_MUTEX_LOCK(__resolv_lock);
>         if (rp == NULL)
> -               rp = __resp;
> +               rp = &_res;
>         __close_nameservers();
>         __res_sync = NULL;
>  #ifdef __UCLIBC_HAS_IPV6__
>
> That seems to build ....

I have pushed a fix for this.
Thanks,


Sent with AquaMail for Android
http://www.aqua-mail.com