res_state and res_init definition order in resolv.c

[Sørensen, Kenneth]

Hi Bernhard

While you are looking into this issue will you please take my suggested patches into consideration?

http://lists.uclibc.org/pipermail/uclibc/2013-April/047721.html
This one specifically addresses the issue described below.

http://lists.uclibc.org/pipermail/uclibc/2013-April/047722.html
This one makes res_init() thread safe.

http://lists.uclibc.org/pipermail/uclibc/2013-April/047723.html
Please see my explanation in the mail.

Thank you for your time.

/Kenneth
________________________________________
From: uclibc-bounces at uclibc.org <uclibc-bounces at uclibc.org> on behalf of Bernhard Reutner-Fischer <rep.dot.nop at gmail.com>
Sent: Monday, July 15, 2013 11:41
To: Eugene Rudoy; uclibc at uclibc.org
Subject: Re: res_state and res_init definition order in resolv.c

On 13 July 2013 13:17:25 Eugene Rudoy <gene.devel at gmail.com> wrote:
> Hi all,
>
> could someone who is familiar with resolv.c and understands all its res_init
> related tricks please comment the following two commits:
>
> [1] "resolv.c: add support for per thread
> res_state"<http://git.uclibc.org/uClibc/commit/libc/inet/resolv.c?id=aab4df0fb51660300559f5f29290709db2f7bfee>.
> Note
> the comment it contains "This needs to be after the use of _res in
> res_init, above."
>
> and
>
> [2] "inet/resolv: add res_ninit and
> res_nclose"<http://git.uclibc.org/uClibc/commit/libc/inet/resolv.c?id=7f74de5d4d6d10baafab4b37bb3d472f5c5f0e8c>.
> This
> moves res_init after the definition of _res/__resp without modifying the
> comment from [1] and without explaining whether it still applies or not.
>
> The question arises in the context of understanding whether the patch
> provided in OpenWRT ticket 11929 <https://dev.openwrt.org/ticket/11929> is
> a correct one and why it works for some people and doesn't work for the
> other ones.

I will have a look.
Thanks,


Sent with AquaMail for Android
http://www.aqua-mail.com


_______________________________________________
uClibc mailing list
uClibc at uclibc.org
http://lists.busybox.net/mailman/listinfo/uclibc