Regression caused by future merge utent.c, wtent.c: move functions from utxent.c

Khem Raj raj.khem at gmail.com
Tue Sep 11 04:39:02 UTC 2012


Hi Peter/Bernhard

We have a regression on master which is that systemd does not boot the system anymore
whereas it works fine with 0.9.33 branch so I did not bisecting and this boiled down
to below commit. If I revert that then everything is working again. Please take a look
what could be wrong here. The commit comment "The smaller size on utent.os is unexpected, could be due to better inlining/not inlining"
does not effuse lot of confidence in this patch. I would ask to revert this commit if
there is no easy resolution.

commit 84135275cfeebc0b233c1c96eeada4d4178a0b18
Author: Peter S. Mazinger <ps.m at gmx.net>
Date:   Tue Mar 15 15:29:14 2011 +0100

    utent.c, wtent.c: move functions from utxent.c
    
    before the change (threads enabled)
       text        data     bss     dec     hex filename
       1107           8     408    1523     5f3 libc/misc/utmp/utent.os
        152           0       0     152      98 libc/misc/utmp/wtent.os
        240           0       0     240      f0 libc/misc/utmp/utxent.os
    after the change
       text        data     bss     dec     hex filename
       1072           8     408    1488     5d0 libc/misc/utmp/utent.os
        157           0       0     157      9d libc/misc/utmp/wtent.os
        200           0       0     200      c8 libc/misc/utmp/utxent.os
    
    The smaller size on utent.os is unexpected, could be due to better inlining/not inlining
    
    Signed-off-by: Peter S. Mazinger <ps.m at gmx.net>
    Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop at gmail.com>


-- 
-Khem


More information about the uClibc mailing list