[PATCH] prevent retries on fclose/fflush after write errors

Rich Felker dalias at aerifal.cx
Tue Mar 13 05:58:49 UTC 2012


On Tue, Mar 13, 2012 at 01:41:01AM -0400, Mike Frysinger wrote:
> On Sunday 11 March 2012 11:12:19 Denys Vlasenko wrote:
> > --- a/libc/sysdeps/linux/common/bits/uClibc_stdio.h
> > +++ b/libc/sysdeps/linux/common/bits/uClibc_stdio.h
> > @@ -250,6 +250,7 @@ struct __STDIO_FILE_STRUCT {
> >  	unsigned char __ungot[2];
> >  #endif /* __UCLIBC_HAS_WCHAR__ */
> >  	int __filedes;
> > +	int __errno_value;
> >  #ifdef __STDIO_BUFFERS
> >  	unsigned char *__bufstart;	/* pointer to buffer */
> >  	unsigned char *__bufend;	/* pointer to 1 past end of buffer */
> 
> pretty sure this breaks ABI.  i know we aren't completely strict on this, but 
> it's something we should avoid if possible.
> -mike

How so? Application code should not be touching the internals of
FILE...

Rich


More information about the uClibc mailing list