[PATCH] libc: remove pointless inclusion of kernel_types.

Khem Raj raj.khem at gmail.com
Tue Jan 24 01:04:47 UTC 2012


On (23/01/12 19:59), Carmelo AMOROSO wrote:
> Indeed, the common, mips and xtensa version of pread_write.c do not
> refer any of types defined in kernel_types.h, so not needed
> to include this header.
> 
> (Build untested on mips, xtensa)

looks ok to me. There are further patches in future branch which unify
pread_write.c

> 
> Signed-off-by: Carmelo Amoroso <carmelo.amoroso at st.com>
> CC: Chris Zankel <chris at zankel.net>
> CC: Khem Raj <raj.khem at gmail.com>
> ---
>  libc/sysdeps/linux/common/pread_write.c |    2 --
>  libc/sysdeps/linux/mips/pread_write.c   |    3 ---
>  libc/sysdeps/linux/xtensa/pread_write.c |    2 --
>  3 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/libc/sysdeps/linux/common/pread_write.c b/libc/sysdeps/linux/common/pread_write.c
> index 88e6957..855b1c8 100644
> --- a/libc/sysdeps/linux/common/pread_write.c
> +++ b/libc/sysdeps/linux/common/pread_write.c
> @@ -25,8 +25,6 @@ extern __typeof(pread64) __libc_pread64;
>  extern __typeof(pwrite64) __libc_pwrite64;
>  #endif
>  
> -#include <bits/kernel_types.h>
> -
>  #ifdef __NR_pread
>  
>  # define __NR___syscall_pread __NR_pread
> diff --git a/libc/sysdeps/linux/mips/pread_write.c b/libc/sysdeps/linux/mips/pread_write.c
> index ea6b15f..5518844 100644
> --- a/libc/sysdeps/linux/mips/pread_write.c
> +++ b/libc/sysdeps/linux/mips/pread_write.c
> @@ -33,9 +33,6 @@ extern __typeof(pread64) __libc_pread64;
>  extern __typeof(pwrite64) __libc_pwrite64;
>  #endif
>  
> -#include <bits/kernel_types.h>
> -
> -
>  #ifdef __NR_pread
>  
>  # if _MIPS_SIM == _MIPS_SIM_ABI64
> diff --git a/libc/sysdeps/linux/xtensa/pread_write.c b/libc/sysdeps/linux/xtensa/pread_write.c
> index 71ba22b..beeb203 100644
> --- a/libc/sysdeps/linux/xtensa/pread_write.c
> +++ b/libc/sysdeps/linux/xtensa/pread_write.c
> @@ -25,8 +25,6 @@ extern __typeof(pread64) __libc_pread64;
>  extern __typeof(pwrite64) __libc_pwrite64;
>  #endif
>  
> -#include <bits/kernel_types.h>
> -
>  #ifdef __NR_pread
>  
>  # define __NR___syscall_pread __NR_pread
> -- 
> 1.7.4.4
> 

-- 
-Khem


More information about the uClibc mailing list