Future branch status

[Bernhard Reutner-Fischer]

On 26 April 2012 18:08, Khem Raj <raj.khem at gmail.com> wrote:
> On Thu, Apr 26, 2012 at 8:18 AM, Bernhard Reutner-Fischer
> <rep.dot.nop at gmail.com> wrote:
>>> Another thing: with LD_SO_CACHE=y O_CLOEXEC is not defined (you removed all the
>>> _GNU_SOURCE and we did not yet adjust it for susv4) so ldso fails to build with:
>>>  CC ldso/ldso/ldso.oS
>>> In file included from ldso/ldso/ldso.c:1432:0:
>>> ldso/ldso/dl-elf.c: In function '_dl_map_cache':
>>> ldso/ldso/dl-elf.c:54:45: error: 'O_CLOEXEC' undeclared (first use in
>>> this function)
>>
>> Disregard this, i had to fix your OABI vs EABI check since otherwise
>> pregen headers
>> barfed (since the did not include the config). Fixed now by including
>> uClibc_config.h in the
>> arm arch_features before the abi check.
>
> I have some patches on top too which are not on the branch I posted
> this was one of them
>
> From 7ff5e8b59f629bc83f4dbaf7d76dbecccf50b122 Mon Sep 17 00:00:00 2001
> From: Khem Raj <raj.khem at gmail.com>
> Date: Tue, 7 Feb 2012 19:54:17 -0800
> Subject: [PATCH] includes: uClibc_arch_features.h now depends on
>  uClibc_config.h
>
> Adjust for the dependency so include features.h from
> libc-symbols.h which is included on compiler cmdline
> which otherwise misses the symbols from uClibc_config.h
> since it only included bits/uClibc_arch_features.h
>
> So we include both bits/uClbc_configs.h and bits/uClibc_arch_features.h
> in features.h and include features.h in libc-symbols.h
> which then takes care of dependencies
>
> Signed-off-by: Khem Raj <raj.khem at gmail.com>
> ---
>  include/features.h     |    1 +
>  include/libc-symbols.h |    2 +-
>  2 files changed, 2 insertions(+), 1 deletions(-)
>
> Index: git/include/libc-symbols.h
> ===================================================================
> --- git.orig/include/libc-symbols.h     2012-02-07 21:09:02.885347078 -0800
> +++ git/include/libc-symbols.h  2012-02-07 21:11:56.097355232 -0800
> @@ -48,6 +48,9 @@
>
>    */
>
> +#define __need_uClibc_config_h
> +# include <bits/uClibc_config.h>
> +#undef __need_uClibc_config_h
>  #include <bits/uClibc_arch_features.h>
>
>  /* Enable declarations of GNU extensions, since we are compiling them.  */

This does not seem to work too well either.

See "arm: consistency check OABI v. EABI" in the updated tarball.

We end up with the aeabi_unwind dummies undefined since upon
generating uClibc_config.h
the IS_EABI check tries to read uClibc_config.h which fails and so the
IS_EABI files are not
included in the lib.

Alternatively we could compile a check-file that errors out if ABIs do
not match.
I am more inclined to remove the check altogether and give the user
what she asked for.

Short term i am removing the -include from flags for just this check
to make it work. Should be revisited..