getaddrinfo() optimization

[Bernhard Reutner-Fischer]

On 3 April 2012 16:48, Alexander Komyagin <komyagin at altell.ru> wrote:
> Hello!
>
> I found out that getaddrinfo() function in uclibc may cause performance
> downgrades for some heavy-loaded services (e.g. squid) due to
> unnecessary calls to __check_pf() (and hence getifaddrs() ). Really
> these calls only needed when AI_ADDRCONFIG hint flag is given.
>
> For example, squid uses getaddrinfo() to convert IP addresses from
> textual to numeric form, providing just AI_NUMERICHOST hint flag. You
> can imagine how many calls there are when you have about 1000 requests
> per second and the overhead from netlink communications to kernel every
> time in getifaddrs().

yes, good catch.
>
> Small simple patch to fix this issue is attached.

You forgot the Signed-Off-By line. See http://uclibc.org/developing#contrib
Please resend (with c89 quotes).
TIA!
>
>
> --
> Best wishes,
> Alexander Komyagin
>
> _______________________________________________
> uClibc mailing list
> uClibc at uclibc.org
> http://lists.busybox.net/mailman/listinfo/uclibc