Patch: Blowfish and SHA support for crypt

Rich Felker dalias at aerifal.cx
Mon Oct 24 11:37:51 UTC 2011


On Mon, Oct 24, 2011 at 01:00:05PM +0200, Bernhard Reutner-Fischer wrote:
> As to the sha256 implementation, it uses nested functions and as such
> will fail to build for (ancient) c89/c90 only bootstrap compilers, so
> please note this fact in the help-text of the config entry.
> PS: please don't forget a Signed-off-by line when you resend.

Much worse, it will fail for any actual C compiler (as opposed to "GNU
C" compilers) as well as on any system with non-executable stack.
Please fix by replacing the code with valid C. "Nested functions" are
not valid C and can trivially be replaced by putting your local
variables in a struct context and passing a pointer to it to the
function that would have been a nested function.

Rich


More information about the uClibc mailing list