[PATCH] buildsys: fix pregen target (!NPTL with LOCALE)

[Bernhard Reutner-Fischer]

On May 30, 2011 2:41 PM, "Carmelo AMOROSO" <carmelo.amoroso at st.com> wrote:
>
> On 30/05/2011 14.37, Carmelo AMOROSO wrote:
> > When NPTL is not enabled, and LOCALE support is used, compilation fails
> > with the following error:
> >
> >
-------------------------------------------------------------------------
> >   MKDIR include/bits
> >   GEN include/bits/sysnum.h
> > make[1]: *** No rule to make target
`../..//include/bits/uClibc_ctype.h', needed by
`../../extra/locale/gen_wc8bit.c'.  Stop.
> > make: *** [pregen] Error 2
> >
-------------------------------------------------------------------------
> >
> > The problem is that "headers" is not listed as prerequisite of pregen.
> > These have been changed multiple times recently:
> >
> >       o       Austin: order headers before pregen-headers
> >               1f5c73c9f8a98b1d2a35cea868a585c97ab0e436
> >       o       Khem: pregen: Fix the parallel build problem in pregen
target
> >               046035ecde92262d96eff2192ba3cda716f04909
> >       o       Khem: pregen-headers: Add new target which depends on
headers.
> >               ef18cfe8ebab25f5ef92e81956f50e2dc57df602
> >       o       Carmelo: build: Fix infinite loop when no threading
support is enabled
> >               ff5e4de7088fe8d34812c2a1e604bf04be713606
> > In all of these commits headers was actually as prerequisite
> >
> > In commit 9381d622e2411a35a5fd73a5a573eb269e2dd9c9 [nptl: fix buildsys]
by Bernhard, headers was removed,
> > causing the problem reported above.
> >
> > Signed-off-by: Filippo Arcidiacono <filippo.arcidiacono at st.com>
> > Signed-off-by: Carmelo Amoroso <carmelo.amoroso at st.com>
> > ---
> >  Makefile.in |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/Makefile.in b/Makefile.in
> > index 2f8370b..31ba89e 100644
> > --- a/Makefile.in
> > +++ b/Makefile.in
> > @@ -161,7 +161,7 @@ headers-y += $(target-headers-sysdep)
> >  headers: $(top_builddir)include/bits/uClibc_config.h | subdirs
> >  subdirs: $(addprefix $(top_builddir),$(subdirs))
> >  pregen-headers: $(top_builddir)include/bits/sysnum.h
$(pregen-headers-y)
> > -pregen: pregen-headers
> > +pregen: headers pregen-headers
> >       $(Q)$(if $(UCLIBC_HAS_LOCALE),$(MAKE) -C extra/locale
locale_headers)
> >
> >  $(top_builddir)include/bits/sysnum.h:
$(top_srcdir)extra/scripts/gen_bits_syscall_h.sh |
$(top_builddir)include/bits
>
> Bernard,
> I guess that the change in pregen/pregen-headers was not related with
> the changes of commit 9381d622e2411a35a5fd73a5a573eb269e2dd9c9, and it
> was accidental, so I think we can apply this patch.

Adding headers as a prerequisite of prevent is not strictly correct but OK
as a workaround for now, so please install.
>
> Thanks,
> Carmelo
>
> _______________________________________________
> uClibc mailing list
> uClibc at uclibc.org
> http://lists.busybox.net/mailman/listinfo/uclibc