[PATCH v2] pread_write.c: added cancellation for all architectures

Peter Mazinger ps.m at gmx.net
Mon May 16 23:06:27 UTC 2011


-------- Original-Nachricht --------
> Datum: Mon, 16 May 2011 13:09:43 -0700
> Von: Maksim Rayskiy <maksim.rayskiy at gmail.com>
> An: Rich Felker <dalias at aerifal.cx>, Peter Mazinger <ps.m at gmx.net>
> CC: uclibc at uclibc.org
> Betreff: Re: [PATCH v2] pread_write.c: added cancellation for all architectures

> Hi,
> 
> On Sun, May 15, 2011 at 8:03 PM, Rich Felker <dalias at aerifal.cx> wrote:
> >
> > I vote for removing the emulation completely.
> >
> 
> I can remove the fallback code from the patch if you agree on that,
> but I cannot even compile it for architectures that do not support
> pread/pwrite syscalls.
> How is it to be tested then?

if you remove it, then it can't be tested anymore (it will go to stubs.c and return -1/setting ENOSYS probably -haven't read manual to see if that applies).

If we remove fallback codes generally, that should not be a one-man-decision, see how list reacts, maybe we can agree upon some rule

Peter
-- 
Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir
belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de


More information about the uClibc mailing list