[PATCH] pread_write.c: add cancellation to mips pread/pwrite

Rich Felker dalias at aerifal.cx
Fri May 13 00:11:09 UTC 2011


On Thu, May 12, 2011 at 11:01:19PM +0200, Peter Mazinger wrote:
> 
> > From: Maksim Rayskiy <mrayskiy at broadcom.com>
> > 
> > pread() and pwrite() are mandatory cancellation points.
> > copypasted from sh implementation
> 
> please take care about all archs, it is not OK, that only some of
> them got the cancellation support (or adapt my patch from future branch that generalized it for all archs)

Making arch-specific .c files for functions like this is really a
silly practice that leads to bugs like that. There's no reason it
can't be a common .c file, with #if ULONG_MAX > 0xffffffff or
something.

Rich


More information about the uClibc mailing list