[PATCH 1/3] libc_elf: improve auxiliary vector handling

Carmelo AMOROSO carmelo.amoroso at st.com
Tue May 3 10:21:52 UTC 2011


On 5/3/2011 1:39 AM, Kevin Cernekee wrote:
[SNIP]
> 
>> -   /* Get the number of program headers from the aux vect */
>> -   _dl_phnum = (size_t) av[AT_PHNUM].a_un.a_val;
>> +	for (; av->a_type < AT_NUM; ++av) {
>> +		switch (av->a_type) {
> 
> FWIW, that does result in mixed indentation styles in dl-support.c .
> 
>> +	for (; av->a_type < AT_NUM; ++av) {
> 

Oh I see. You are referring to the indentation by 2 spaces used in the
other function defined (that really looks very bad).

I'd change it later (instead of keeping on using on new code a so bad
coding style.

I also recognized that usually we should not force change in coding
style on old code, so I'm available for both option.

Opinion ?

Carmelo


More information about the uClibc mailing list