[PATCH 2/3] nptl: Fix start_thread() for _STACK_GROWS_UP
Carmelo AMOROSO
carmelo.amoroso at st.com
Wed Jan 19 10:48:13 UTC 2011
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 1/19/2011 10:55 AM, Will Newton wrote:
> On Wed, Jan 19, 2011 at 9:14 AM, Carmelo AMOROSO <carmelo.amoroso at st.com> wrote:
> >> diff --git a/libpthread/nptl/pthread_create.c b/libpthread/nptl/pthread_create.c
> >> index 63e5588..42ffbaf 100644
> >> --- a/libpthread/nptl/pthread_create.c
> >> +++ b/libpthread/nptl/pthread_create.c
> >> @@ -383,7 +383,8 @@ start_thread (void *arg)
> >> char *sp = CURRENT_STACK_FRAME;
> >> size_t freesize = (sp - (char *) pd->stackblock) & ~pagesize_m1;
> >> #else
> >> -# error "to do"
> >> + char *sp = CURRENT_STACK_FRAME;
> >> + size_t freesize = ((char *) pd->stackblock - sp) & ~pagesize_m1;
> >> #endif
> >> assert (freesize < pd->stackblock_size);
> >> if (freesize > PTHREAD_STACK_MIN)
> >> --
> >> 1.7.2.2
> >> _______________________________________________
> >> uClibc mailing list
> >> uClibc at uclibc.org
> >> http://lists.busybox.net/mailman/listinfo/uclibc
> >>
> >
> > Lookg good. On which arch have you tested it ?
>
> Our arch is currently out of tree. I think the only other arch with
> this kind of upside down stack is parisc, but I haven't been able to
> test on of those.
>
ok, thanks.
carmelo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk02wW0ACgkQoRq/3BrK1s92LgCfRd1dyWVysKAr1zd27Prv/Qzs
MZwAniwTosj9+9vCWWlV0o+zwjRzK6H4
=jGif
-----END PGP SIGNATURE-----
More information about the uClibc
mailing list