[PATCH 3/3] Add __pause_nocancel weak alias.

Carmelo AMOROSO carmelo.amoroso at st.com
Wed Jan 19 09:12:31 UTC 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 1/12/2011 1:07 PM, Will Newton wrote:
> On architectures that don't provide __NR_pause __pause_nocancel is
> needed when wanting to perform an uncancelable pause.
> 
> Signed-off-by: Matt Fleming <matthew.fleming at imgtec.com>
> ---
> libc/sysdeps/linux/common/pause.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/libc/sysdeps/linux/common/pause.c
> b/libc/sysdeps/linux/common/pause.c
> index ab16fa7..036f6a3 100644
> --- a/libc/sysdeps/linux/common/pause.c
> +++ b/libc/sysdeps/linux/common/pause.c
> @@ -34,6 +34,7 @@ __libc_pause (void)
> return sigsuspend (&set);
> }
> weak_alias (__libc_pause, pause)
> +weak_alias (__libc_pause, __pause_nocancel)
> 
> #ifdef __UCLIBC_HAS_THREADS_NATIVE__
> LIBC_CANCEL_HANDLED (); /* sigsuspend handles our cancellation. */

Hi Will,
if you use NPTL (do you ?), due to the call to sigsupend (that is a
cancellable function too) your __pause_nocancel is actually a
cancellation point. So I'm not sure you issue is fixed.

Am I wrong ?

Carmelo



> --
> 1.7.2.2
> _______________________________________________
> uClibc mailing list
> uClibc at uclibc.org
> http://lists.busybox.net/mailman/listinfo/uclibc
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk02qv8ACgkQoRq/3BrK1s9xcACg2SDMZFfoskpCO75rvUIkPEcR
kY0AoKeyLnIixkh/e+ttfZ4i8N2kg9w2
=sNTC
-----END PGP SIGNATURE-----


More information about the uClibc mailing list