[PATCH] buildsys: headers target should not depend on sysnum.h

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Thu Jan 6 09:38:50 UTC 2011


"Carmelo AMOROSO" <carmelo.amoroso at st.com> wrote:

>-----BEGIN PGP SIGNED MESSAGE-----
>Hash: SHA1
>
>On 1/5/2011 11:23 AM, Carmelo Amoroso wrote:
>> On 1/5/2011 9:06 AM, Bernhard Reutner-Fischer wrote:
>>> On Tue, Jan 04, 2011 at 11:36:12AM +0100, Carmelo AMOROSO wrote:
>>>  >From: Filippo Arcidiacono <filippo.arcidiacono at st.com>
>>>  >
>>>  >The generation of the sysnum.h has to be a prerequisite of
>>>  >'pregen' target instead of headers, because it needs the compiler
>>>  >already available.
>>>  >The so called C bootstrap headers are required to build the
>compiler
>>>  >by invoking 'make headers', so the 'headers' target cannot relies
>itself
>>>  >on the compiler to be invoked.
>> 
>>> please add sysnum.h to pregen-headers-y instead.
>>> TIA,
>> 
>> ok. I'll redo, test, and commit ;-)
>> 
>> carmelo
>
>Hi Bernhard,
>doing
>pregen-headers-y += $(top_builddir)include/bits/sysnum.h
>does not work fine in every case. It should be added before including
>all the other subdirs/Makefile.in because some of nptl pregen-headers-y
>needs sysnum.h. I don't like this solution "context" sensitive.
>So I'd suggest this way:
>pregen-headers: $(top_builddir)include/bits/sysnum.h
>$(pregen-headers-y)
>
>(it works also for parallel build without problems)
>
>What do you think ?
>
>Carmelo
>
>-----BEGIN PGP SIGNATURE-----
>Version: GnuPG v1.4.10 (MingW32)
>Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
>iEYEARECAAYFAk0kWn0ACgkQoRq/3BrK1s/iDQCeObEiL0I84aMOpkZwYDdkqu+j
>54cAn2cuyGPOQionby8cmfrd50XDAULX
>=bRTh
>-----END PGP SIGNATURE-----

Hi,

Yes, please install.


More information about the uClibc mailing list