[PATCH <branch>] hint

[Carmelo AMOROSO]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bernhard Reutner-Fischer wrote:
> On Fri, Dec 18, 2009 at 08:17:50AM +0100, Carmelo AMOROSO wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
> 
> [catching up on mail backlog..]
> 
>> Hi All,
>> for all git-format-patch users, I would suggest to specify in the
>> [PATCH] subject the branch name too {master,nptl,0_9_28,0_9_29,0_9_30}
>> to help reviewer/committers
>>
>> The option to be used with format-patch is --subject-prefix="[PATCH <branch>]"
>>
>> Sorry for experienced git users that already know this.
> 
> I've tried that with both the version packaged by debian as well as
> git's master branch and it doesn't seem to work for me? ¹)
> 
> I do:
> $ git config --replace-all format.subjectprefix 'PATCH <branch>'
> # edit something, commit it
> $ git format-patch -o ~/foo/ HEAD^..HEAD
> and that patch still has "<branch>" in the subject, even when
> send-email'ed.
> 
> What am i doing wrong?
> 

Hi Berhard,
likely I was not so clear. I meant to pass the --subject-prefix to the git format-patch
command, I did not mean an way to automatically detect the working branch.

So what I do is:

git-format-patch -o ~/foo/ HEAD^..HEAD --subject-prefix="PATCH my_working_branch"
and I got the following

- --------
- From c07d6a85ba7e9653829b4b29336b246effb2defd Mon Sep 17 00:00:00 2001
From: Giuseppe Cavallaro <peppe.cavallaro at st.com>
Date: Mon, 13 Jul 2009 10:38:24 +0200
Subject: [PATCH my_working_branch] sh: add assembly strcpy and strncpy

This patch adds the strcpy and strncpy assembly routines.
- -------

You did a bit step toward ;)

> ¹) With attached patchlet against git master it works as you advertise
> above. You must be using a similar patch in your git-core?

I think this is could be really useful.

>> Cheers,
>> Carmelo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAktK6SwACgkQoRq/3BrK1s/epgCcDUpU1gr25rxKmlH8861Dzg6l
1I0AoI7eefNrEmTbcebVEnB2wT5vy3ab
=wNnP
-----END PGP SIGNATURE-----