[PATCH] nptl i686: fix pthread_cond_wait.S compilation

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Thu Aug 5 22:01:40 UTC 2010


On Thu, Aug 05, 2010 at 05:30:11PM -0400, Mike Frysinger wrote:
>On Wednesday, July 14, 2010 09:19:29 Roman I Khimov wrote:
>> __i686 is a gcc-defined macro, so i686 build failed with:
>> libpthread/nptl/sysdeps/unix/sysv/linux/i386/i686/../i486/pthread_cond_wait
>> .S: Assembler messages:
>> 
>> --- a/libpthread/nptl/sysdeps/unix/sysv/linux/i386/i686/pthread_cond_wait.S
>> +++ b/libpthread/nptl/sysdeps/unix/sysv/linux/i386/i686/pthread_cond_wait.S
>> @@ -17,4 +17,5 @@
>>     Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
>>     02111-1307 USA.  */
>> 
>> +#undef __i686
>>  #include "../i486/pthread_cond_wait.S"
>
>i dont think this is the proper way to fix this.  put the undef in the i386 
>sysdep.h header file so all random files with a thunk section get fixed 
>automatically.

That's of course better, thanks!


More information about the uClibc mailing list