[git commit master] math.h: fix trivial typo (missing !): !defined __NO_LONG_DOUBLE_MATH
Denys Vlasenko
vda.linux at googlemail.com
Sat Sep 5 22:12:08 UTC 2009
On Saturday 05 September 2009 23:57, Mike Frysinger wrote:
> > > > - fcntl(LogFile, F_SETFD, 1); /* 1 == FD_CLOEXEC */
> > > > + fcntl(LogFile, F_SETFD, FD_CLOEXEC);
> > > > /* We don't want to block if e.g. syslogd is SIGSTOPed */
> > > > fcntl(LogFile, F_SETFL, O_NONBLOCK | fcntl(LogFile, F_GETFL));
> > > > }
> > >
> > > please try to avoid committing unrelated things
> >
> > I know.
> > I am too lazy to do four commits for four one-liners :(
>
> this might have been merged with the CLOEXEC patch as a general cloexec
> cleanup, but it certainly should not be stuck in with random other changes
> regardless of the size. i know it's more effort than was required in the
> past, but the end result makes navigating git history a hell of a lot easier
> (especially when looking for regressions).
You are right.
This particular fubar was accidental - I just forgot that I edited
that line with FD_CLOEXEC.
I didn't tell you that since it sounds like I'm looking for an excuse.
I don't - I know it's wrong to mix changes like I do.
--
vda
More information about the uClibc
mailing list