[git commit master] futimens: add function

Mike Frysinger vapier at gentoo.org
Sun Nov 22 00:42:53 UTC 2009


On Friday 20 November 2009 14:05:07 Bernhard Reutner-Fischer wrote:
> --- /dev/null
> +++ b/libc/sysdeps/linux/common/futimens.c
> @@ -0,0 +1,23 @@
> +#include <sys/syscall.h>
> +#define __need_timespec
> +#include <time.h>
> +#ifdef __NR_utimensat
> +extern int utimensat (int __fd, __const char *__path,
> +	__const struct timespec __times[2],
> +	int __flags) __THROW;
> +libc_hidden_proto(utimensat)
> +
> +int futimens (int fd, __const struct timespec ts[2])
> +{
> +	return utimensat(fd, 0, ts, 0);
> +}
> +#endif

you've added the hidden proto to the header which defines utimensat, so why 
are you duplicating it here ?  makes no sense to do this ...

also, these sprinkling of __need_xxx around in source files looks wrong
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/uclibc/attachments/20091121/571d191d/attachment.pgp>


More information about the uClibc mailing list