svn commit: trunk/uClibc/test/crypt

Denys Vlasenko vda.linux at googlemail.com
Wed Mar 4 18:32:28 UTC 2009


On Wednesday 04 March 2009 04:41:41 pm Salvatore CRO' wrote:
> Hi Carmelo,
> Attached is a proposal tailored for rpc test that could be very easily
> extedend to all tests in uClibc. Indeed it avoids "include ../../.config" in
> test Makefile by :
> 
>   - creating a new file Makefile.in with the same contents of existing
> Makefile but "include ../Test.mak"
>   - replacing existing Makefile by a new one that only does some includes,
> first one being "include ../Rules.mak" (that in turns got "include
> ../../.config"), then includes the new Makefile.in and finally ../Test.mak
>   - removing "include ../Rules.mak" from ../Test.mak, since we've just done
> it in Makefile.
> 
> By including ../Rules.mak first, we ensure that _actual_ UCLIBC_HAS_xxx
> values (through ../../.config) get evaluated by Makefile.in to arrange the
> TESTS variable so that all due sources are correctly compiled.
> 
> Using this approach, Makefile is the same for all tests and contains include
> statements only while all test-specific settings lie in the new Makefile.in 

The cure seems to be worse than the disease:

# diffstat z
 Test.mak        |    3 ---
 rpc/Makefile    |   11 +++--------
 rpc/Makefile.in |   11 +++++++++++
 3 files changed, 14 insertions(+), 11 deletions(-)

and this includes creation of a new file.

Why you can't just add one line, "include ../../.config", instead?
--
vda


More information about the uClibc mailing list