svn commit: trunk/uClibc: include libc/string libc/string/generic etc...

Denys Vlasenko vda.linux at googlemail.com
Mon Jul 20 20:36:36 UTC 2009


On Monday 20 July 2009 14:22, Mike Frysinger wrote:
> On Friday 13 February 2009 07:37:52 Bernhard Reutner-Fischer wrote:
> > On Tue, Dec 16, 2008 at 05:36:32PM -0800, vda at uclibc.org wrote:
> > >Author: vda
> > >Date: 2008-12-16 17:36:31 -0800 (Tue, 16 Dec 2008)
> > >New Revision: 24435
....
> > >+static __always_inline
> > >+void *inlined_memchr_const_c(const void *s, int c, size_t count)
> > >+{
> > >+	void *edi;
> > >+	int ecx, eax;
> > >+	__asm__ __volatile__(
> > >+		"	jecxz	1f\n"
> > >+		"	movb	%4, %%al\n" /* const c to %%al */
> > >+		"	repne; scasb\n"
> > >+		"	leal	-1(%%edi), %%edi\n"
> > >+		"	je	2f\n"
> > >+		"1:\n"
> > >+		"	xorl	%%edi, %%edi\n"
> > >+		"2:\n"
> > >+		: "=&D" (edi), "=&c" (ecx), "=&a" (eax)
> > >+		: "0" (s), "i" (c), "1" (count)
> > >+		/* : no clobbers */
> > >+	);
> >
> > Are you sure? Sounds like there is a bug somewhere for it works with any
> > optimization level on gcc 4.4 as opposed to anything earlier:
> >
> > ./include/libc-string_i386.h: In function '__stdio_fwrite':
> > ./include/libc-string_i386.h:293: warning: asm operand 4 probably doesn't
> > match constraints
> > ./include/libc-string_i386.h:293: error: impossible constraint in 'asm'

IIUC operand 4 is c, which has to be constant here, since we do:

#define memchr(s, c, count) ( \
        __builtin_constant_p(c) \
        ? inlined_memchr_const_c(s, (c) & 0xff, count) \
        : inlined_memchr(s, c, count) \
        )


__stdio_fwrite uses "memchr(buffer, '\n', pending)", so c == '\n' -
definitely a constant, not unusual in any way.

"objdump -dr _fwrite.o" shows:
...
  8d:   e3 09                   jecxz  98 <__stdio_fwrite+0x98>
  8f:   b0 0a                   mov    $0xa,%al
  91:   f2 ae                   repnz scas %es:(%edi),%al
  93:   8d 7f ff                lea    -0x1(%edi),%edi
  96:   74 02                   je     9a <__stdio_fwrite+0x9a>
  98:   31 ff                   xor    %edi,%edi
  9a:   85 ff                   test   %edi,%edi
  9c:   74 37                   je     d5 <__stdio_fwrite+0xd5>
...


> and now i'm hitting this too.  if a fix isnt coming soon, then i say we just 
> disable it until it's actually usable.


With attached config, and i486-linux-uclibc-XXX
toolchain, it works for me.

# i486-linux-uclibc-gcc -v
Using built-in specs.
Target: i486-linux-uclibc
Configured with: ../gcc-4.3.1/configure --prefix=/usr/app/gcc-4.3.1-i486-linux-uclibc --exec-prefix=/usr/app/gcc-4.3.1-i486-linux-uclibc --bindir=/usr/app/gcc-4.3.1-i486-linux-uclibc/bin --sbindir=/usr/app/gcc-4.3.1-i486-linux-uclibc/sbin --libexecdir=/usr/app/gcc-4.3.1-i486-linux-uclibc/libexec --datadir=/usr/app/gcc-4.3.1-i486-linux-uclibc/share --sysconfdir=/etc --sharedstatedir=/usr/app/gcc-4.3.1-i486-linux-uclibc/var/com --localstatedir=/usr/app/gcc-4.3.1-i486-linux-uclibc/var --libdir=/usr/app/gcc-4.3.1-i486-linux-uclibc/lib --includedir=/usr/app/gcc-4.3.1-i486-linux-uclibc/include --infodir=/usr/app/gcc-4.3.1-i486-linux-uclibc/info --mandir=/usr/app/gcc-4.3.1-i486-linux-uclibc/man --disable-nls --with-local-prefix=/usr/local --with-slibdir=/usr/app/gcc-4.3.1-i486-linux-uclibc/lib --with-gxx-include-dir=/usr/app/gcc-4.3.1-i486-linux-uclibc/include/g++-v3 --build=i386-pc-linux-gnu --host=i386-pc-linux-gnu --target=i486-linux-uclibc --with-gnu-ld --with-ld=/usr/bin/i486-linux-uclibc-ld --with-gnu-as --with-as=/usr/bin/i486-linux-uclibc-as --with-sysroot=/usr/cross/i486-linux-uclibc --enable-languages=c,c++ --enable-target-optspace --disable-shared --disable-__cxa_atexit --disable-threads --disable-tls --disable-multilib --without-headers --disable-decimal-float --disable-libgomp
Thread model: single
gcc version 4.3.1 (GCC)

Can you send me your .config, preprocessed source
and gcc command line which gives you trouble?

What does your gcc -v say?

--
vda
-------------- next part --------------
#
# Automatically generated make config: don't edit
# Version: 0.9.30-svn
# Mon Jul 20 22:18:36 2009
#
# TARGET_alpha is not set
# TARGET_arm is not set
# TARGET_avr32 is not set
# TARGET_bfin is not set
# TARGET_cris is not set
# TARGET_e1 is not set
# TARGET_frv is not set
# TARGET_h8300 is not set
# TARGET_hppa is not set
TARGET_i386=y
# TARGET_i960 is not set
# TARGET_ia64 is not set
# TARGET_m68k is not set
# TARGET_microblaze is not set
# TARGET_mips is not set
# TARGET_nios is not set
# TARGET_nios2 is not set
# TARGET_powerpc is not set
# TARGET_sh is not set
# TARGET_sh64 is not set
# TARGET_sparc is not set
# TARGET_v850 is not set
# TARGET_vax is not set
# TARGET_x86_64 is not set
# TARGET_xtensa is not set

#
# Target Architecture Features and Options
#
TARGET_ARCH="i386"
FORCE_OPTIONS_FOR_ARCH=y
# CONFIG_GENERIC_386 is not set
# CONFIG_386 is not set
CONFIG_486=y
# CONFIG_586 is not set
# CONFIG_586MMX is not set
# CONFIG_686 is not set
# CONFIG_PENTIUMII is not set
# CONFIG_PENTIUMIII is not set
# CONFIG_PENTIUM4 is not set
# CONFIG_K6 is not set
# CONFIG_K7 is not set
# CONFIG_ELAN is not set
# CONFIG_CRUSOE is not set
# CONFIG_WINCHIPC6 is not set
# CONFIG_WINCHIP2 is not set
# CONFIG_CYRIXIII is not set
# CONFIG_NEHEMIAH is not set
TARGET_SUBARCH=""

#
# Using ELF file format
#
ARCH_LITTLE_ENDIAN=y

#
# Using Little Endian
#
ARCH_HAS_MMU=y
ARCH_USE_MMU=y
UCLIBC_HAS_FLOATS=y
UCLIBC_HAS_FPU=y
DO_C99_MATH=y
UCLIBC_HAS_FENV=y
UCLIBC_HAS_LONG_DOUBLE_MATH=y
KERNEL_HEADERS="../../linux-2.6.27.9-i386/usr/include"
HAVE_DOT_CONFIG=y

#
# General Library Settings
#
# HAVE_NO_PIC is not set
# DOPIC is not set
# ARCH_HAS_NO_SHARED is not set
# ARCH_HAS_NO_LDSO is not set
# HAVE_SHARED is not set
UCLIBC_CTOR_DTOR=y
# HAS_NO_THREADS is not set
# UCLIBC_HAS_THREADS is not set
UCLIBC_HAS_SYSLOG=y
UCLIBC_HAS_LFS=y
# MALLOC is not set
# MALLOC_SIMPLE is not set
MALLOC_STANDARD=y
# MALLOC_GLIBC_COMPAT is not set
UCLIBC_DYNAMIC_ATEXIT=y
COMPAT_ATEXIT=y
UCLIBC_SUSV3_LEGACY=y
UCLIBC_SUSV3_LEGACY_MACROS=y
UCLIBC_SUSV4_LEGACY=y
UCLIBC_HAS_STUBS=y
UCLIBC_HAS_SHADOW=y
UCLIBC_HAS_PROGRAM_INVOCATION_NAME=y
UCLIBC_HAS___PROGNAME=y
UCLIBC_HAS_PTY=y
ASSUME_DEVPTS=y
UNIX98PTY_ONLY=y
UCLIBC_HAS_GETPT=y
UCLIBC_HAS_TM_EXTENSIONS=y
UCLIBC_HAS_TZ_CACHING=y
UCLIBC_HAS_TZ_FILE=y
UCLIBC_HAS_TZ_FILE_READ_MANY=y
UCLIBC_TZ_FILE_PATH="/etc/TZ"

#
# Advanced Library Settings
#
UCLIBC_PWD_BUFFER_SIZE=256
UCLIBC_GRP_BUFFER_SIZE=256

#
# Support various families of functions
#
UCLIBC_LINUX_MODULE_24=y
UCLIBC_LINUX_SPECIFIC=y
UCLIBC_HAS_GNU_ERROR=y
UCLIBC_BSD_SPECIFIC=y
UCLIBC_HAS_BSD_ERR=y
UCLIBC_HAS_OBSOLETE_BSD_SIGNAL=y
UCLIBC_HAS_OBSOLETE_SYSV_SIGNAL=y
UCLIBC_NTP_LEGACY=y
UCLIBC_SV4_DEPRECATED=y
UCLIBC_HAS_REALTIME=y
UCLIBC_HAS_ADVANCED_REALTIME=y
UCLIBC_HAS_EPOLL=y
UCLIBC_HAS_XATTR=y
UCLIBC_HAS_PROFILING=y
UCLIBC_HAS_CRYPT_IMPL=y
UCLIBC_HAS_CRYPT=y
UCLIBC_HAS_NETWORK_SUPPORT=y
UCLIBC_HAS_SOCKET=y
UCLIBC_HAS_IPV4=y
UCLIBC_HAS_IPV6=y
UCLIBC_HAS_RPC=y
UCLIBC_HAS_FULL_RPC=y
UCLIBC_HAS_REENTRANT_RPC=y
UCLIBC_USE_NETLINK=y
UCLIBC_SUPPORT_AI_ADDRCONFIG=y
UCLIBC_HAS_BSD_RES_CLOSE=y
UCLIBC_HAS_COMPAT_RES_STATE=y
# UCLIBC_HAS_EXTRA_COMPAT_RES_STATE is not set

#
# String and Stdio Support
#
UCLIBC_HAS_STRING_GENERIC_OPT=y
UCLIBC_HAS_STRING_ARCH_OPT=y
UCLIBC_HAS_CTYPE_TABLES=y
UCLIBC_HAS_CTYPE_SIGNED=y
UCLIBC_HAS_CTYPE_UNSAFE=y
# UCLIBC_HAS_CTYPE_CHECKED is not set
# UCLIBC_HAS_CTYPE_ENFORCED is not set
# UCLIBC_HAS_WCHAR is not set
# UCLIBC_HAS_LOCALE is not set
# UCLIBC_HAS_HEXADECIMAL_FLOATS is not set
# UCLIBC_HAS_GLIBC_CUSTOM_PRINTF is not set
# USE_OLD_VFPRINTF is not set
UCLIBC_PRINTF_SCANF_POSITIONAL_ARGS=9
# UCLIBC_HAS_SCANF_GLIBC_A_FLAG is not set
# UCLIBC_HAS_STDIO_BUFSIZ_NONE is not set
# UCLIBC_HAS_STDIO_BUFSIZ_256 is not set
# UCLIBC_HAS_STDIO_BUFSIZ_512 is not set
UCLIBC_HAS_STDIO_BUFSIZ_1024=y
# UCLIBC_HAS_STDIO_BUFSIZ_2048 is not set
# UCLIBC_HAS_STDIO_BUFSIZ_4096 is not set
# UCLIBC_HAS_STDIO_BUFSIZ_8192 is not set
UCLIBC_HAS_STDIO_BUILTIN_BUFFER_NONE=y
# UCLIBC_HAS_STDIO_BUILTIN_BUFFER_4 is not set
# UCLIBC_HAS_STDIO_BUILTIN_BUFFER_8 is not set
# UCLIBC_HAS_STDIO_SHUTDOWN_ON_ABORT is not set
UCLIBC_HAS_STDIO_GETC_MACRO=y
UCLIBC_HAS_STDIO_PUTC_MACRO=y
UCLIBC_HAS_STDIO_AUTO_RW_TRANSITION=y
UCLIBC_HAS_FOPEN_LARGEFILE_MODE=y
UCLIBC_HAS_FOPEN_EXCLUSIVE_MODE=y
# UCLIBC_HAS_GLIBC_CUSTOM_STREAMS is not set
UCLIBC_HAS_PRINTF_M_SPEC=y
UCLIBC_HAS_ERRNO_MESSAGES=y
# UCLIBC_HAS_SYS_ERRLIST is not set
UCLIBC_HAS_SIGNUM_MESSAGES=y
UCLIBC_HAS_SYS_SIGLIST=y
UCLIBC_HAS_GNU_GETOPT=y
UCLIBC_HAS_GNU_GETSUBOPT=y

#
# Big and Tall
#
UCLIBC_HAS_REGEX=y
# UCLIBC_HAS_REGEX_OLD is not set
UCLIBC_HAS_FNMATCH=y
UCLIBC_HAS_FNMATCH_OLD=y
UCLIBC_HAS_WORDEXP=y
UCLIBC_HAS_FTW=y
UCLIBC_HAS_GLOB=y
UCLIBC_HAS_GNU_GLOB=y

#
# Library Installation Options
#
RUNTIME_PREFIX="/lib-i486-linux-uclibc"
DEVEL_PREFIX="/usr"
# HARDWIRED_ABSPATH is not set

#
# Security options
#
UCLIBC_HAS_ARC4RANDOM=y
# HAVE_NO_SSP is not set
# UCLIBC_HAS_SSP is not set
UCLIBC_BUILD_NOEXECSTACK=y

#
# uClibc development/debugging options
#
CROSS_COMPILER_PREFIX="i486-linux-uclibc-"
UCLIBC_EXTRA_CFLAGS=""
# DODEBUG is not set
DOSTRIP=y
# DOASSERTS is not set
# UCLIBC_MALLOC_DEBUGGING is not set
WARNINGS="-Wall -Wunused-parameter"
# EXTRA_WARNINGS is not set
# DOMULTI is not set
# UCLIBC_MJN3_ONLY is not set


More information about the uClibc mailing list