[PATCH] sh: Fix __SH_SYSCALL_TRAP_BASE for SH2A architecture

[Rob Landley]

On Friday 20 February 2009 08:59:11 Carmelo AMOROSO wrote:
> Bernhard Reutner-Fischer wrote:
> > On Fri, Feb 20, 2009 at 03:18:04PM +0100, Bernhard Reutner-Fischer wrote:
> >> On Fri, Feb 20, 2009 at 03:12:34PM +0100, Carmelo AMOROSO wrote:
> >>>>>> +#ifdef __CONFIG_SH2__ | __CONFIG_SH2A__
> >>>>>>  # define __SH_SYSCALL_TRAP_BASE 0x20
> >>>>>>  #else
> >>>>>>  # define __SH_SYSCALL_TRAP_BASE 0x10
> >>>>>
> >>>>> Applied, thanks.
> >>>>
> >>>> err, how could that possibly be correct?
> >>>
> >>> It cannot. Sorry.. just applied. Luckily there are more eyes looking at
> >>> what we do.
> >>
> >> alright, don't get me wrong but please let's just do this properly via
> >> #if defined FOO || defined BAR
> >
> > oh, and probably -DFOO=__sh2__ -DBAR=__SH2A__
>
> why ? I would expect to be defined by gcc itself.
> At least cross gcc for sh4 defines the following
>
> #define __sh__ 1
> #define __SH4__ 1

Fun trick:

  gcc -dM -E - < /dev/null

Spits out all the predefined symbols.

Rob