[PATCH] sh: Fix __SH_SYSCALL_TRAP_BASE for SH2A architecture

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Fri Feb 20 14:34:23 UTC 2009


On Fri, Feb 20, 2009 at 03:18:04PM +0100, Bernhard Reutner-Fischer wrote:
>On Fri, Feb 20, 2009 at 03:12:34PM +0100, Carmelo AMOROSO wrote:
>
>>>>> +#ifdef __CONFIG_SH2__ | __CONFIG_SH2A__ 
>>>>>  # define __SH_SYSCALL_TRAP_BASE 0x20
>>>>>  #else
>>>>>  # define __SH_SYSCALL_TRAP_BASE 0x10
>>>> Applied, thanks.
>>> 
>>> err, how could that possibly be correct?
>>> 
>>It cannot. Sorry.. just applied. Luckily there are more eyes looking at
>>what we do.
>
>alright, don't get me wrong but please let's just do this properly via
>#if defined FOO || defined BAR

oh, and probably -DFOO=__sh2__ -DBAR=__SH2A__
Perhaps you know if a BAZ (aka __SH2E__) should be there too..
>
>TIA and sorry for the nitpicking ;P


More information about the uClibc mailing list