ERROR REPORT: general build error

Douglas Mencken dougmencken at gmail.com
Sat Aug 29 19:04:25 UTC 2009


I used
   > 0_9_30_rc3-484-g6625518
to build uClibc and got
   > libc/libc_so.a(posix_fadvise64.os): In function `posix_fadvise64':
   > posix_fadvise64.c:(.text+0x30): undefined reference to
`__illegally_sized_syscall_arg2'
   > posix_fadvise64.c:(.text+0x34): undefined reference to
`__illegally_sized_syscall_arg3'
   > posix_fadvise64.c:(.text+0x38): undefined reference to
`__illegally_sized_syscall_arg4'
   > posix_fadvise64.c:(.text+0x3c): undefined reference to
`__illegally_sized_syscall_arg5'
   > collect2: ld returned 1 exit status
   > make: *** [lib/libc.so] Error 1
The solution is simple: if syscall requires a 4-bit integer, so  let
'em get it! By simple type-casting. Very-very simple.
Saw bug reports from 2008 and can't understand: what was the problem
to do this very simple fix?

uClibc — ./libc/sysdeps/linux/common/posix_fadvise64.c

[code]
/*
 * posix_fadvise64() for uClibc
 * http://www.opengroup.org/onlinepubs/009695399/functions/posix_fadvise.html
 *
 * Copyright (C) 2000-2006 Erik Andersen <andersen at uclibc.org>
 * Licensed under the LGPL v2.1, see the file COPYING.LIB in this tarball.
 */

#include <features.h>
#include <unistd.h>
#include <errno.h>
#include <endian.h>
#include <stdint.h>
#include <sys/types.h>
#include <sys/syscall.h>
#include <fcntl.h>

#ifdef __UCLIBC_HAS_LFS__
#ifdef __NR_fadvise64_64

/* 64 bit implementation is cake ... or more like pie ... */
#if __WORDSIZE == 64

#define __NR_posix_fadvise64 __NR_fadvise64_64

int posix_fadvise64(int fd, __off64_t offset, __off64_t len, int advice)
{
 if (len != (off_t) len)
   return EOVERFLOW;
 INTERNAL_SYSCALL_DECL (err);
   int ret = INTERNAL_SYSCALL (posix_fadvise64, err, 5, fd,
                              __LONG_LONG_PAIR ((long) (offset >> 32),
                                                (long) offset),
                              (off_t) len, advice);
 if (!INTERNAL_SYSCALL_ERROR_P (ret, err))
   return 0;
 return INTERNAL_SYSCALL_ERRNO (ret, err);
}

/* 32 bit implementation is kind of a pita */
#elif __WORDSIZE == 32

int posix_fadvise64(int fd, __off64_t offset, __off64_t len, int advice)
{
       INTERNAL_SYSCALL_DECL (err);
       int ret = INTERNAL_SYSCALL (fadvise64_64, err, 6, fd,
                              __LONG_LONG_PAIR((long)(offset >> 32),
                                               (long)(offset &  0xffffffff)),
                              __LONG_LONG_PAIR((long)(len >> 32),
                                               (long)(len &
0xffffffff)), advice);
       if (!INTERNAL_SYSCALL_ERROR_P (ret, err))
               return 0;
       return INTERNAL_SYSCALL_ERRNO (ret, err);
}

#else
#error your machine is neither 32 bit or 64 bit ... it must be magical
#endif

#elif !defined __NR_fadvise64
/* This is declared as a strong alias in posix_fadvise.c if __NR_fadvise64
 * is defined.
 */
int posix_fadvise64(int fd, __off64_t offset, __off64_t len, int advice)
{
#warning This is not correct as far as SUSv3 is concerned.
       return ENOSYS;
}
#endif /* __NR_fadvise64_64 */
#endif /* __UCLIBC_HAS_LFS__ */
[/code]


More information about the uClibc mailing list