is cris' OFFS_ALIGN really correct?

[Ricard Wanderlof]

On Wed, 15 Oct 2008, Bernhard Reutner-Fischer wrote:

> Hi,
>
> While moving ldso to use runtime-dynamic pagesizes, i stumbled across an
> irregularity in cris:
> ldso/ldso/cris/dl-sysdep.h:#define OFFS_ALIGN 0xffffe000
>
> for 8k pages, i would have expected this to be 7fffe000, no?
> If the current OFFS_ALIGN on cris is indeed correct, then please add a
> brief comment to above this define which explains this bit.

I must admit I'm not familiar with this piece of code. I'm not even sure 
what OFFS_ALIGN is used for, but as far as I can make out it is used to 
mask out the page bits before calling mmap2; I can't understand why 
0xff... or 0x7f... would make a difference though (in _dl_mmap() it is 
passed as an ulong), but principially I agree; it is 0x7f... for all other 
archs so it should be for Cris too. Is there anywhere this is explained in 
more detail? Can't offhand find the corresponding files in glibc (but my 
glibc may be on the old side too).

/Ricard
--
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30
  --- PLEASE NOTE - I have moved - from F407 to F117 - PLEASE NOTE ---