[PATCH] all arches: c89 touchup

Rob Landley rob at landley.net
Thu Oct 2 04:22:16 UTC 2008


On Tuesday 30 September 2008 12:09:45 Bernhard Reutner-Fischer wrote:
> Hi,
>
> To be gentle to c89 bootstrap-compilers the attached patch does
> basically s/\/\/\(.*\)/\/*\1 *\//g
>
> The corresponding issue is
> http://bugs.uclibc.org/view.php?id=5194
>
> The reporter sees this with gcc-4.2.4 without passing -std=c89 to
> the compiler (i.e. uses the defaults) and as such i find it a bit odd
> that the preprocessor rejects it.
>
> Still, it may be handy if one is able to bootstrap the libc with
> a compiler that is in C89 mode.

Ok, how exactly does one do that?

find uClibc -name "*.[ch]" | xargs grep 'uint[0-9]' | wc
    600    2925   40974

This isn't something we're gonna regression test in the future, no real point 
in pretending, is there?  (One day you're arguing that 4.1.2 is too old to 
work around, now a patch for two decade old standard that was replaced a 
decade ago?)

> PS: yes, i do not fancy such changes but this is harmless and makes
> sense to some degree.
> PPS: Rob, i know that you like C99 style comments, that's not the point
> here ;)

Hey, if I had any designs on maintainership I would have argued with 
your "we're not deprecating linuxthreads.old" Blanket Statement of Policy 
(tm).  You put out -rc1, and you're obviously willing to do the work of the 
maintainer.  I'm happy to step out of the way and let you do it.

I do plan to continue arguing for things I want, though. :)

Rob

P.S.  The reason I'm being annoying about this is I'm trying to come up with a 
decent regression test for all the architectures I can get to run under 
emulators.  I got m68k to build, but qemu only seems to support coldfire and 
not real m68k, so I'm sniffing around for another emulator that might be able 
to boot the kernel and root filesystem I just built.  But I get on a plane in 
13 hours and then I'm back home busy with the backlog there, so progress may 
not exactly be linear...



More information about the uClibc mailing list