[RFC] Fix various compiler warning
Hans-Christian Egtvedt
hans-christian.egtvedt at atmel.com
Mon Nov 3 16:12:00 UTC 2008
When working on latest trunk today I noticed some compiler warnings
here and there. Should I just fix them as indicated in patch below?
Index: libpthread/linuxthreads.old/manager.c
mask is already defined for the function further up, skip compiler warning
by supplying a different name inside this scope.
===================================================================
--- libpthread/linuxthreads.old/manager.c (revision 23911)
+++ libpthread/linuxthreads.old/manager.c (working copy)
@@ -579,9 +579,9 @@
/* See whether the TD_CREATE event bit is set in any of the
masks. */
int idx = __td_eventword (TD_CREATE);
- uint32_t mask = __td_eventmask (TD_CREATE);
+ uint32_t eventmask = __td_eventmask (TD_CREATE);
- if ((mask & (__pthread_threads_events.event_bits[idx]
+ if ((eventmask & (__pthread_threads_events.event_bits[idx]
| event_maskp->event_bits[idx])) != 0)
{
/* Lock the mutex the child will use now so that it will stop. */
Index: libpthread/linuxthreads.old/attr.c
There are quite a lot of these #if <something> which probably should be
#ifdef <something> ?
===================================================================
--- libpthread/linuxthreads.old/attr.c (revision 23911)
+++ libpthread/linuxthreads.old/attr.c (working copy)
@@ -61,7 +61,7 @@
libpthread_hidden_def(pthread_attr_init)
/* uClibc: leave out this for now. */
-#if DO_PTHREAD_VERSIONING_WITH_UCLIBC
+#ifdef DO_PTHREAD_VERSIONING_WITH_UCLIBC
#if defined __PIC__ && defined DO_VERSIONING
default_symbol_version (__pthread_attr_init_2_1, pthread_attr_init, GLIBC_2.1);
--
Best regards,
Hans-Christian Egtvedt
More information about the uClibc
mailing list