[PATCH] mknod fix for major/minor number greater than 255

Basheer, Mansoor Ahamed mansoor.ahamed at ti.com
Thu Mar 27 04:55:18 UTC 2008



Bernhard Fischer wrote:

> 
> This change does definitely not look ok, given that it seems to only
fix
> a fraction of affected arches, AFAICS?
> 
> $ egrep "short.*kernel_dev_t" */bits/*.h
> arm/bits/kernel_types.h:typedef unsigned short
__kernel_dev_t;
> bfin/bits/kernel_types.h:typedef unsigned short __kernel_dev_t;
> cris/bits/kernel_types.h:typedef unsigned short __kernel_dev_t;
> e1/bits/kernel_types.h:typedef unsigned short   __kernel_dev_t;
> frv/bits/kernel_types.h:typedef unsigned short  __kernel_dev_t;
> h8300/bits/kernel_types.h:typedef unsigned short
__kernel_dev_t;
> i386/bits/kernel_types.h:typedef unsigned short __kernel_dev_t;
> m68k/bits/kernel_types.h:typedef unsigned short __kernel_dev_t;
> nios/bits/kernel_types.h:typedef unsigned short __kernel_dev_t;
> sh/bits/kernel_types.h:typedef unsigned short   __kernel_dev_t;
> sh64/bits/kernel_types.h:typedef unsigned short  __kernel_dev_t;
> sparc/bits/kernel_types.h:typedef unsigned short
__kernel_dev_t;
> vax/bits/kernel_types.h:typedef unsigned short  __kernel_dev_t;

Yes I agree, even other arches have to be fixed. I could validate my
changes only on ARM arch. 



More information about the uClibc mailing list