svn commit: trunk/uClibc/ldso/ldso/sh

Carl SHAW carl.shaw at st.com
Tue Jan 15 12:47:15 UTC 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Paul Mundt wrote:
> On Sat, Jan 12, 2008 at 07:06:02PM +0100, Carmelo Amoroso wrote:
>> Mike Frysinger wrote:
>>> On Saturday 12 January 2008, carmelo at uclibc.org wrote:
>>>> Author: carmelo
>>>> Date: 2008-01-12 00:20:18 -0800 (Sat, 12 Jan 2008)
>>>> New Revision: 20848
>>>>
>>>> Log:
>>>> Make sh4 build works again adding a temporary work-around
>>>> iby redefining __always_inline to inline until gcc 4.x.x will get
>>>> fixed.
>>>>
>>>> Modified:
>>>>    trunk/uClibc/ldso/ldso/sh/dl-syscalls.h
>>>>
>>>> +#warning !!! __always_inline redefined waiting for the fixed gcc
>>>> +#ifdef __always_inline
>>>> +#undef __always_inline
>>>> +#define __always_inline inline
>>>> +#endif
>>> shouldnt you leverage __GNUC_PREREQ(4, 0) ?  and add information about what 
>>> version of gcc is actually broken ?
>>> -mike
>>>
>> Hi Mike,
>> done. I'm assuming the problem is with gcc 4.1 and later.
>>
> If your new compiler is sane enough to define __GNUC_STM_RELEASE__ as was
> discussed before, it might be worth conditionalizing on that also. We
> already do that in the kernel for some other cases..

Yes, the new compiler does (and we will continue to in future, although
we expect to push back our changes to gcc).  We got burnt with that one
before.

Carl
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHjKtTsOYe+9JwoiQRAtq3AKCb+TDnsaYSrsHdHO9qZdtsxllO8QCfWcHz
V1meZGkqSOHcXUqjPkBMGlU=
=3XcY
-----END PGP SIGNATURE-----



More information about the uClibc mailing list