[PATCH] bug in __check_pf() (getaddrinfo.c)

Ricard Wanderlof ricard.wanderlof at axis.com
Sun Dec 7 22:59:49 UTC 2008


On Sat, 6 Dec 2008, Hiroshi Shinji wrote:

> Hi Khem,
> Thanks for your comment.
>
> 2008/12/6 Khem Raj <raj.khem at gmail.com>:
>> Getting NULL for ifa_addr means that the interface has no address. Do
>> you know in what cases does this happen. Patch looks ok though.
>
> True. My environment has a interface that has no address.
>
> And, previous source code had another problem. 'for' statement had no 
> '{' and '}'. Therefore, If you defined both __UCLIBC_HAS_IPV4__ and 
> __UCLIBC_HAS_IPV6__, the second 'if' statement would be outside of the 
> for-loop and occure segfault.

This stuff seems to continuously come back and haunt me ... :-( (I was the 
original poster of check_pf-stuff, although it has been modified since 
then so can't take credit for all the problems. :-) Patch looks good to me 
anyway.

/Ricard
--
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30



More information about the uClibc mailing list