svn commit: branches/uClibc-nptl/libpthread: nptl nptl/sysdeps/generic nptl/sysdeps/p etc...

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Wed Dec 3 18:21:43 UTC 2008


On Wed, Dec 03, 2008 at 09:53:18AM -0800, carmelo at uclibc.org wrote:
>Author: carmelo
>Date: 2008-12-03 09:53:17 -0800 (Wed, 03 Dec 2008)
>New Revision: 24246
>
>Log:
>Rework nptl build system for cleaning headers and objects
>to be compliant with all other Makefile.
>The output of the make clean (silent mode) will be as follows:

>Modified: branches/uClibc-nptl/libpthread/nptl/Makefile.in
>===================================================================
>--- branches/uClibc-nptl/libpthread/nptl/Makefile.in	2008-12-03 14:07:45 UTC (rev 24245)
>+++ branches/uClibc-nptl/libpthread/nptl/Makefile.in	2008-12-03 17:53:17 UTC (rev 24246)

> nptl_headers_clean:
>-	$(RM) $(PTDIR)/banner.h $(top_builddir)include/pthread.h	\
>-	      $(PTDIR)/version.h $(top_builddir)include/semaphore.h	\
>+	$(do_rm) $(addprefix $(top_builddir),$(nptl_headers_bootstrap)) \
> 	      $(PTHREAD_OUT)/pthread-errnos.{c,h,s}

The primary reason why do_rm was added was to be gentle to shells which do not
do bash-like globs. Please refer to the samples on trunk.

PS: It would be nice if we would move to use something like $(call do_rm,....)
mid-term since with that it should be easier to pretty-print the dirname of
the affected files once and correctly (as you can see i cheat with the names
a bit right now). Any volunteers?


>Modified: branches/uClibc-nptl/libpthread/nptl/sysdeps/unix/sysv/linux/Makefile.in
>===================================================================
>--- branches/uClibc-nptl/libpthread/nptl/sysdeps/unix/sysv/linux/Makefile.in	2008-12-03 14:07:45 UTC (rev 24245)
>+++ branches/uClibc-nptl/libpthread/nptl/sysdeps/unix/sysv/linux/Makefile.in	2008-12-03 17:53:17 UTC (rev 24246)
>@@ -130,7 +130,7 @@
> librt-a-y += $(LIBRT_LINUX_OBJ)
> librt-so-y += $(LIBRT_LINUX_OBJ:.o=.oS)
> 
>-objclean-y += nptl_linux_objclean
>+objclean-y += nptl_linux_clean
> headers_clean-y += nptl_linux_headers_clean
> 
> #
>@@ -188,11 +188,13 @@
> $(ALL_HEADERS_BITS_PTHREAD):
> 	$(do_ln) ../../$(PTHREAD_LINUX_DIR)/bits/$(@F) $(top_builddir)$@
> 	
>+nptl_linux_headers_all:= $(PTHREAD_LINUX_OUT)/lowlevelbarrier.{c,h,s}	\
>+	$(PTHREAD_LINUX_OUT)/lowlevelcond.{c,h,s}		\
>+	$(PTHREAD_LINUX_OUT)/lowlevelrwlock.{c,h,s}	\
>+	$(PTHREAD_LINUX_OUT)/unwindbuf.{c,h,s}

breaks too, fwiw




More information about the uClibc mailing list