FD-PIC patches for uClibc

Alexandre Oliva aoliva at redhat.com
Fri Nov 30 05:58:35 UTC 2007


Hi, Bernd,

Thanks for pushing these patches out!

On Nov 29, 2007, Bernd Schmidt <bernds_cb1 at t-online.de> wrote:

> -char *_dl_find_hash(const char *name, struct dyn_elf *rpnt, struct elf_resolve *mytpnt, int type_class)
> +char *_dl_lookup_hash(const char *name, struct dyn_elf *rpnt,
> +		      struct elf_resolve *mytpnt, int type_class,
> +#ifdef __FDPIC__
> +		      struct elf_resolve **tpntp
> +#endif
> +		      )

The comma after type_class will break ifndef __FDPIC__.

This is just another strong indications that ifdefs in prototypes are
a terrible idea ;-)

-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
FSF Latin America Board Member         http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}



More information about the uClibc mailing list