[PATCH] Avoid near-infinite looping in __gen_tempname

Nickolai Zeldovich nickolai at cs.stanford.edu
Mon Apr 30 21:43:46 UTC 2007


On 4/30/07, Mike Frysinger <vapier at gentoo.org> wrote:
> On Sunday 22 April 2007, Nickolai Zeldovich wrote:
> > The code to create a unique file (mktemp) has a logic error in uClibc.
> >  When __gen_tempname picks a file name that already exists, the code
> > attempts to retry.  However, the code to pick a new file name is
> > outside of this retry loop, causing a retry with the same exact
> > filename, which is very likely to fail again.  This patch fixes this
> > problem by moving the random filename generation code inside the retry
> > loop:
>
> so attach your patch since the URL here is unavailable

Patch attached.

Nickolai.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: uclibc-tempname-patch
Type: application/octet-stream
Size: 997 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/uclibc/attachments/20070430/ec2353d8/attachment-0002.obj 


More information about the uClibc mailing list