svn commit: branches/uClibc-nptl: include libc/misc/internals libpthread/n etc...

Peter S. Mazinger ps.m at gmx.net
Thu Jan 5 08:50:12 UTC 2006


On Wed, 4 Jan 2006 sjhill at uclibc.org wrote:

> Author: sjhill
> Date: 2006-01-04 17:25:30 -0800 (Wed, 04 Jan 2006)
> New Revision: 13094
> 
> Log:
> Changes to make 'h_errno' be a TLS variable. These changes should be portable into the trunk as, I think, they handle both thread and non-threaded cases and maybe only minor tweaks to handle the linuxthreads model, if any.
> 
> 
> Modified:
>    branches/uClibc-nptl/include/netdb.h
>    branches/uClibc-nptl/libc/misc/internals/Makefile.in
>    branches/uClibc-nptl/libc/misc/internals/__h_errno_location.c
>    branches/uClibc-nptl/libpthread/nptl/sysdeps/unix/sysv/linux/Makefile.in
> 
> 
> Modified: branches/uClibc-nptl/libc/misc/internals/Makefile.in
> ===================================================================
> --- branches/uClibc-nptl/libc/misc/internals/Makefile.in	2006-01-05 01:20:21 UTC (rev 13093)
> +++ branches/uClibc-nptl/libc/misc/internals/Makefile.in	2006-01-05 01:25:30 UTC (rev 13094)
> @@ -17,7 +17,7 @@
>  MISC_INTERNALS_OBJ:=$(patsubst %.c,$(MISC_INTERNALS_OUT)/%.o,$(CSRC))
>  
>  libc-a-y+=$(MISC_INTERNALS_OBJ)
> -libc-so-y+=$(MISC_INTERNALS_OBJ:.o=.os)
> +libc-so-y+=$(MISC_INTERNALS_OBJ:.o=.oS)
>  libc-shared-y+=$(MISC_INTERNALS_OUT)/__uClibc_main.oS
>  libc-static-y+=$(MISC_INTERNALS_OUT)/__uClibc_main.o

this will build all files w/ -DSHARED, is it necessary? We could generally 
do it for lib*-so-y, but that will force us to build 2 objects all the 
time (if DO_PIC is enabled). I would rather limit the list to those files 
that have ifdef SHARED, keeping the others common for libc-so/libc-a

> Modified: branches/uClibc-nptl/libpthread/nptl/sysdeps/unix/sysv/linux/Makefile.in
> ===================================================================
> --- branches/uClibc-nptl/libpthread/nptl/sysdeps/unix/sysv/linux/Makefile.in	2006-01-05 01:20:21 UTC (rev 13093)
> +++ branches/uClibc-nptl/libpthread/nptl/sysdeps/unix/sysv/linux/Makefile.in	2006-01-05 01:25:30 UTC (rev 13094)
> @@ -43,7 +43,6 @@
>  CFLAGS-linux = -DNOT_IN_libc=1 -DIS_IN_libpthread=1 $(SSP_ALL_CFLAGS)
>  #CFLAGS:=$(CFLAGS:-O1=-O2)
>  
> -CFLAGS-OMIT-libc-lowlevellock.c = -DNOT_IN_libc=1 -DIS_IN_libpthread=1
>  CFLAGS-OMIT-libc_pthread_init.c = -DNOT_IN_libc=1 -DIS_IN_libpthread=1

I wonder why nptl adds libc_pthread_init.c to libpthread and not to libc 
(as current trunk does)

>  libc-a-y += $(LIBC_OBJ)
> -libc-so-y += $(LIBC_OBJ:.o=.os)
> +libc-so-y += $(LIBC_OBJ:.o=.oS)

same comment as for libc/misc/internals, doubling the build time for 
DO_PIC=y

-- 
Peter S. Mazinger <ps dot m at gmx dot net>           ID: 0xA5F059F2
Key fingerprint = 92A4 31E1 56BC 3D5A 2D08  BB6E C389 975E A5F0 59F2




More information about the uClibc mailing list