[PATCH] Fix undefined MAP_FAILED in _dl_mmap()

Nicolas Bellido ml at acolin.be
Wed Feb 22 08:24:49 UTC 2006


On Wednesday 22 February 2006 01:57, Mike Frysinger wrote:
> On Tuesday 21 February 2006 16:53, Nicolas Bellido wrote:
> > On Tuesday 21 February 2006 15:20, Mike Frysinger wrote:
> > > On Tuesday 21 February 2006 04:15, Nicolas Bellido wrote:
> > > > Also, because of the #if 0 ... #endif surrounding the definition of
> > > > _dl_mmap_check_error in ldso/include/dl-syscall.h, if an architecture
> > > > does not provide the mmap syscall, _dl_mmap would not compile because
> > > > it uses MAP_FAILED, and not _dl_MAX_ERRNO.
> > >
> > > but this hasnt come up before as everyone provides mmap at this time
> > > ...
> >
> > How about this ?
>
> i'm pretty sure that isnt what we want to do ... the manpage for mman2()
> says that the syscall will return -1 on failure, so ive committed a related
> version instead

Ouch! Yes, you're right, of course.

> -mike

Nicolas



More information about the uClibc mailing list