svn commit: trunk/uClibc/libc/sysdeps/linux/common

[Mike Frysinger]

On Thu, Dec 01, 2005 at 10:53:48AM +0100, Peter S. Mazinger wrote:
> On Wed, 30 Nov 2005 vapier at uclibc.org wrote:
> > +/* need to hide the posix_fadvise64 prototype or the weak_alias()
> > + * will fail when __NR_fadvise64_64 doesnt exist */
> > +#define posix_fadvise64 __hide_posix_fadvise64
> >  #include "syscalls.h"
> >  #include <fcntl.h>
> > +#undef posix_fadvise64
> 
> can't follow here, #define and #undef posix_fadvise64 ? is it so, to 
> "allow" fcntl.h to see it ?

the comment explains it pretty well ... need to hide the
posix_fadvise64 prototype

> > -weak_alias(__libc_posix_fadvise, posix_fadvise);
> > -weak_alias(__libc_posix_fadvise, posix_fadvise64);
> > +weak_alias(posix_fadvise, posix_fadvise64);
> 
> won't you need __libc_posix_fadvise in new libpthread ?

linuxthreads doesnt call posix_fadvise anywhere
> 
> > +#define __NR___syscall_fadvise64_64 __NR_fadvise64_64
> >  _syscall6(int, __syscall_fadvise64_64, int, fd,
> >            unsigned long, high_offset, unsigned long, low_offset,
> >            unsigned long, high_len, unsigned long, low_len,
> >            int, advice);
> 
> why not static [inline] _syscall6 (...) ?

*shrug* should be fine adding static inline
-mike